Skip to content

feat: Adding tags variable for the aws_iam_role resource#84

Open
Yiskaneto (yiskaneto) wants to merge 10 commits into
philips-labs:mainfrom
yiskaneto:feat-add-tags-var-as-input-for-oidc-idp
Open

feat: Adding tags variable for the aws_iam_role resource#84
Yiskaneto (yiskaneto) wants to merge 10 commits into
philips-labs:mainfrom
yiskaneto:feat-add-tags-var-as-input-for-oidc-idp

Conversation

@yiskaneto

@yiskaneto Yiskaneto (yiskaneto) commented Feb 27, 2024

Copy link
Copy Markdown

As we create resources is always a good practice to keep tags for them. This PR adds the tags argument to the aws_iam_role resource which reads its value from the tags variables.

Tested using Terraform and Terragrunt without any issues.

@github-actions github-actions Bot added the minor label Feb 27, 2024
@yiskaneto

Copy link
Copy Markdown
Author

Niek Palm (@npalm) it looks like the change I proposed was actually added as part of https://github.com/philips-labs/terraform-aws-github-oidc/releases/tag/v0.8.1, so for now I will just add some modifications to the main README.md. Please let me know if this is ok.

@yiskaneto Yiskaneto (yiskaneto) changed the title feat: Adding tags variable to the aws_iam_openid_connect_provider resource feat: Adding tags variable aws_iam_role resource Jul 20, 2024
@yiskaneto

Yiskaneto (yiskaneto) commented Jul 20, 2024

Copy link
Copy Markdown
Author

Niek Palm (@npalm) it looks like the change I proposed was actually added as part of https://github.com/philips-labs/terraform-aws-github-oidc/releases/tag/v0.8.1, so for now I will just add some modifications to the main README.md. Please let me know if this is ok.

Actually I just realized the aws_iam_role resource doesn't have the tags argument, so I'm proposing the addition of such argument on this PR, I updated the docs as well and changed the title and description of the PR.

@yiskaneto Yiskaneto (yiskaneto) changed the title feat: Adding tags variable aws_iam_role resource feat: Adding tags variable for the aws_iam_role resource Jul 20, 2024
@ScottGuymer

Copy link
Copy Markdown
Member

Apologies for necroing this PR...

We now tend to use provider level tagging so that all resources get tagged at the same time with the same tags. This prevents the needs to pass in all sorts of tags and potentially forget to add tags to various resources.

Is there any use case for adding specific tags here or using them only on specific resources?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants