feat: Adding tags variable for the aws_iam_role resource#84
feat: Adding tags variable for the aws_iam_role resource#84Yiskaneto (yiskaneto) wants to merge 10 commits into
Conversation
|
Niek Palm (@npalm) it looks like the change I proposed was actually added as part of https://github.com/philips-labs/terraform-aws-github-oidc/releases/tag/v0.8.1, so for now I will just add some modifications to the main README.md. Please let me know if this is ok. |
Actually I just realized the |
|
Apologies for necroing this PR... We now tend to use provider level tagging so that all resources get tagged at the same time with the same tags. This prevents the needs to pass in all sorts of tags and potentially forget to add tags to various resources. Is there any use case for adding specific tags here or using them only on specific resources? |
As we create resources is always a good practice to keep tags for them. This PR adds the tags argument to the
aws_iam_roleresource which reads its value from thetagsvariables.Tested using Terraform and Terragrunt without any issues.