fix: catch exceptions while constructing a step fixture

[Daan Timmer (daantimmer)]

Exceptions were already caught when executing a step (hook implementation or step implementation).

But custom step test fixtures could also throw (missing context values, ASSERT_'s etc). These were not caught.

This PR ensures both the construction of a step and the execution of a step are properly inside a try/catch block.

[github-actions]

✅⚠️MegaLinter analysis: Success with warnings

Descriptor	Linter	Files	Fixed	Errors	Warnings	Elapsed time
✅ ACTION	actionlint	6		0	0	0.24s
✅ ACTION	zizmor	6	0	0	0	2.05s
✅ CPP	clang-format	238	1	0	0	1.57s
✅ DOCKERFILE	hadolint	1		0	0	0.04s
⚠️ MARKDOWN	markdownlint	7	4	20	0	0.88s
✅ MARKDOWN	markdown-table-formatter	7	4	0	0	0.2s
✅ REPOSITORY	betterleaks	yes		no	no	1.19s
✅ REPOSITORY	git_diff	yes		no	no	0.08s
✅ REPOSITORY	grype	yes		no	no	45.83s
✅ REPOSITORY	ls-lint	yes		no	no	0.01s
✅ REPOSITORY	secretlint	yes		no	no	4.44s
✅ REPOSITORY	syft	yes		no	no	2.06s
✅ REPOSITORY	trivy	yes		no	no	10.91s
✅ REPOSITORY	trivy-sbom	yes		no	no	0.38s
✅ REPOSITORY	trufflehog	yes		no	no	4.9s
⚠️ SPELL	lychee	86		1	0	54.63s
✅ YAML	prettier	10	0	0	0	0.56s
✅ YAML	v8r	10		0	0	7.83s
✅ YAML	yamllint	10		0	0	0.54s

Detailed Issues

⚠️ SPELL / lychee - 1 error

📝 Summary
---------------------
🔍 Total..........178
🔗 Unique.........172
✅ Successful.....177
⏳ Timeouts.........0
🔀 Redirected......81
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........1
⛔ Unsupported......1

Errors in CONTRIBUTING.md
[404] https://github.com/yourname/amp-cucumber-cpp-runner.git (at 41:36) | Rejected status code: 404 Not Found | Followed 1 redirect. Redirects: https://github.com/yourname/amp-cucumber-cpp-runner.git --[301]--> https://github.com/yourname/amp-cucumber-cpp-runner

Hint: Followed 81 redirects. You might want to consider replacing redirecting URLs with the resolved URLs. Use verbose mode (`-v`/`-vv`) to see redirection details.
Hint: You can configure accepted/rejected response codes with `-a` or `--accept`

⚠️ MARKDOWN / markdownlint - 20 errors

CHANGELOG.md:31 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:38 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]
CHANGELOG.md:44 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:51 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:58 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:66 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "⚠ BREAKING CHANGES"]
CHANGELOG.md:70 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:79 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:85 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:93 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "⚠ BREAKING CHANGES"]
CHANGELOG.md:97 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:102 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]
CHANGELOG.md:111 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:122 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:130 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "⚠ BREAKING CHANGES"]
CHANGELOG.md:134 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:159 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]
CHANGELOG.md:166 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
cmake/WindowsToolchainFilesProvidedBy.md:1 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "<https://github.com/MarkSchofi..."]
README.md:132 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

• Documentation: Custom Flavors
• Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,ACTION_ZIZMOR,CPP_CLANG_FORMAT,DOCKERFILE_HADOLINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_GIT_DIFF,REPOSITORY_BETTERLEAKS,REPOSITORY_GRYPE,REPOSITORY_LS_LINT,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

Show us your support by starring ⭐ the repository

[Copilot]

Pull request overview

This PR extends the existing step exception handling so that exceptions thrown during step fixture construction (not just during step/hook execution) are also caught and converted into a proper TestStepResult.

Changes:

• Introduced a BodyFactory + ConstructAndExecute(...) flow to ensure both construction and execution are inside the same try/catch.
• Extracted the common exception-to-TestStepResult mapping into a shared utility (HandleErrors).
• Added an acceptance test that verifies a failing step fixture is reported as a test failure (with the thrown message).

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
cucumber_cpp/Steps.hpp	Adds an explicit include for engine/Hook.hpp needed for re-exported types.
cucumber_cpp/library/util/ExecuteAndCatchExceptions.hpp	New helper for mapping caught exceptions into TestStepResult.
cucumber_cpp/library/util/Body.hpp	Refactors the execution API to use BodyFactory and introduces ConstructAndExecute.
cucumber_cpp/library/util/Body.cpp	Implements ConstructAndExecute and routes exception handling through HandleErrors.
cucumber_cpp/library/runtime/Worker.cpp	Switches hook execution to the new factory-based construction+execution path.
cucumber_cpp/library/runtime/TestCaseRunner.cpp	Switches step/hook invocation to BodyFactory + ConstructAndExecute.
cucumber_cpp/library/runtime/NestedTestCaseRunner.cpp	Switches nested step invocation to BodyFactory + ConstructAndExecute.
cucumber_cpp/example/steps/Steps.cpp	Updates example includes to use the new umbrella header.
cucumber_cpp/acceptance_test/test.bats	Adds an acceptance test asserting fixture-construction failures are reported.
cucumber_cpp/acceptance_test/steps/UsedUnused.cpp	Updates include to cucumber_cpp/Steps.hpp.
cucumber_cpp/acceptance_test/steps/Steps.cpp	Adds a failing step fixture and updates includes.
cucumber_cpp/acceptance_test/features/test_step_fixture_failure.feature	New feature file covering step fixture construction failure.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Test Results

29 tests  +2   29 ✅ +2   13s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 85947a6. ± Comparison against base commit afb217f.

♻️ This comment has been updated with latest results.

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 8 comments.

[Xavier Bernhardt (XavierBernhardt-Philips)]

nitpicks fix them

[Copilot]

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 8 comments.

Comments suppressed due to low confidence (1)

cucumber_cpp/library/test/TestApplication.cpp:10

• This test file includes gMock/gTest headers twice (quoted and <...> forms). Keeping only one set avoids redundant includes and potential include-path inconsistencies.

#include "gmock/gmock.h"
#include "gtest/gtest.h"
#include <CLI/Error.hpp>
#include <array>
#include <cstddef>
#include <gmock/gmock.h>
#include <gtest/gtest.h>

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud