Skip to content

Feature/ble advertising debug logging#805

Draft
oguzcan oguz (oguzcanoguz) wants to merge 6 commits into
mainfrom
feature/ble-advertising-debug-logging
Draft

Feature/ble advertising debug logging#805
oguzcan oguz (oguzcanoguz) wants to merge 6 commits into
mainfrom
feature/ble-advertising-debug-logging

Conversation

@oguzcanoguz

Copy link
Copy Markdown
Contributor

No description provided.

- Enable Idle and Advertising radio activity events via aci_hal_set_radio_activity_mask(0x0003) in GapSt constructor
- Dispatch HCI_HARDWARE_ERROR_EVT_CODE to new HandleHciHardwareErrorEvent virtual hook in GapSt
- Dispatch ACI_HAL_END_OF_RADIO_ACTIVITY_VSEVT_CODE to new HandleAciHalEndOfRadioActivityEvent virtual hook in GapSt
- TracingGapPeripheralSt logs the hardware error code on HCI hardware error events
- TracingGapPeripheralSt logs Last_State and Next_State on each radio activity event; when an advertising slot completes (Last_State == 0x01) also calls aci_hal_get_link_status() and logs all link statuses

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Map numeric state/status/error codes to descriptive strings for
radio activity events, link status entries and hardware error codes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ertising

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Attention: Pull Request Description is Empty

Empty pull request descriptions are not allowed by our Way of Working.

The PR description should summarize code changes made and provide context to why changes were required. This can also be provided by a link to a story/task, if the link provides sufficient information. This is to maintain good code history and aid reviewers.

Please provide an adequate description for this pull request.

@github-actions

Copy link
Copy Markdown
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

⚠️ Details

No release type found in pull request title "Feature/ble advertising debug logging". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

@github-actions

Copy link
Copy Markdown
Contributor

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 7 0 0 0.09s
✅ CPP clang-format 15 2 0 0 1.54s
✅ CPP cppcheck 15 0 0 0.83s
✅ DOCKERFILE hadolint 1 0 0 0.03s
✅ JSON jsonlint 7 0 0 0.32s
✅ JSON prettier 7 2 0 0 1.89s
⚠️ MARKDOWN markdownlint 6 1 10 0 2.37s
✅ MARKDOWN markdown-table-formatter 6 1 0 0 1.61s
✅ REPOSITORY checkov yes no no 44.77s
✅ REPOSITORY git_diff yes no no 1.3s
✅ REPOSITORY grype yes no no 73.49s
✅ REPOSITORY ls-lint yes no no 0.07s
✅ REPOSITORY secretlint yes no no 90.15s
✅ REPOSITORY syft yes no no 1.92s
✅ REPOSITORY trivy yes no no 27.32s
✅ REPOSITORY trivy-sbom yes no no 3.09s
✅ REPOSITORY trufflehog yes no no 13.88s
⚠️ SPELL lychee 34 1 0 88.25s
✅ YAML prettier 10 1 0 0 2.16s
✅ YAML v8r 10 0 0 9.29s
✅ YAML yamllint 10 0 0 0.6s

Detailed Issues

⚠️ SPELL / lychee - 1 error
[IGNORED] tcp://localhost:1234/target/echo/programmer | Unsupported: Error creating request client: builder error for url (tcp://localhost:1234/target/echo/programmer)
[ERROR] http://mcd.rou.st.com/modules.php?name=mcu | Network error: error sending request for url (http://mcd.rou.st.com/modules.php?name=mcu) Maybe a certificate error?
[TIMEOUT] https://st.com/ | Timeout
📝 Summary
---------------------
🔍 Total..........239
✅ Successful.....236
⏳ Timeouts.........1
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........1

Errors in README.md
[TIMEOUT] https://st.com/ | Timeout

Errors in .github/ISSUE_TEMPLATE/add-or-update-hal-driver.md
[ERROR] http://mcd.rou.st.com/modules.php?name=mcu | Network error: error sending request for url (http://mcd.rou.st.com/modules.php?name=mcu) Maybe a certificate error?
⚠️ MARKDOWN / markdownlint - 10 errors
.github/ISSUE_TEMPLATE/add-or-update-hal-driver.md:10 error MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: "How to import a HAL driver"]
CHANGELOG.md:83 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "⚠ BREAKING CHANGES"]
CHANGELOG.md:87 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:94 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]
CHANGELOG.md:103 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:122 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]
CHANGELOG.md:140 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "⚠ BREAKING CHANGES"]
CHANGELOG.md:144 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:151 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:162 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.4.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,CPP_CPPCHECK,CPP_CLANG_FORMAT,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GRYPE,REPOSITORY_LS_LINT,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant