Add tab-completion#235
Open
achuie wants to merge 2 commits intophilj56:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tab-completion behavior. When tab is pressed, if the current input is not the same as the current selection, the input is replaced with the current selection. If they do match, the current selection is moved to the next result, similar to the original behavior. Shift+tab works with the same comparison to select the previous result.
I can make this a configurable option instead of default, if desired.
Apologies if I'm missing details, I didn't find any contribution guidelines. Happy to fix anything wrong.
Fixes #232