Implement double parsing for font-size#240
Open
Nimplex wants to merge 9 commits intophilj56:masterfrom
Open
Conversation
Patched from: F-4Dev@11c16a3 (modified to remove clutter) Co-authored-by: F-4Dev <fabian.imgrund2@gmail.com>
Patch: philj56@53f8f62 Patch: achuie@2556f72 Co-authored-by: achuie <achuie@protonmail.com> Co-authored-by: rdap <43019545+rdap@users.noreply.github.com>
Updated README to reflect fork status and added new features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation only accepts integers for font size, which is incorrect. Many bitmap fonts use fixed font sizes (for example, Departure Mono, which uses 11px or 8.5pt at 96 DPI). This PR only adds simple function to parse
doubles and and implements it around the code.