Post-refactoring and improving of the new batch tags update flow#580

Draft

MareStare wants to merge 30 commits into

philomena-dev:masterfrom

MareStare:fix/tag-changes-edge-cases

Commits on May 20, 2025

Eliminate redundant `tag_change` preload
MareStare
committed
Eliminate the redundant `tag` preload
MareStare
committed
Add a `create` match arm for the case when no tag changes were selected
MareStare
committed
Fix the type error
MareStare
committed
Add "tags affected" info to the tag revert result flash
MareStare
committed
To be safe don't change the return type of `Images.batch_update`
MareStare
committed
Add some type specs to `create_image`
MareStare
committed
Uninline the `mass_revert_tags` function
MareStare
committed
Accept [{tag_change_id, tag_id}] in mass_revert_tags`
MareStare
committed
Use Ecto DSL
MareStare
committed
Use `principal` terminology in image
MareStare
committed
Start simple tests for tag changes
MareStare
committed
Test add/remove combinations
MareStare
committed
Reduce the data slightly
MareStare
committed
Refactor
MareStare
committed
Denest
MareStare
committed
Move stuff into reusable `snap` functions
MareStare
committed
More comments
MareStare
committed
More refactoring in the sake of god of refactoring
MareStare
committed
Wait for image upload in `create_image` test util
MareStare
committed
Expose the DB port in docker-compsoe
MareStare
committed
Add some tests for the tag reverts
MareStare
committed
Add a test for reverting the change that was later overwritten. Currently probably not the intended behavior?
MareStare
committed
Add `files` dependency dependency to `app` since test now upload images
MareStare
committed
Don't revert tag changes that were later overwritten
MareStare
committed
Add more comments
MareStare
committed
Better comments
MareStare
committed
Remove the now-unnecessary uniq_by
MareStare
committed
Yay, the tag reverts are now taking into account self-cancelling reverts, tests pass
MareStare
committed
Use `Enum.each()`
MareStare
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Post-refactoring and improving of the new batch tags update flow#580

Post-refactoring and improving of the new batch tags update flow#580
MareStare wants to merge 30 commits into
philomena-dev:masterfrom
MareStare:fix/tag-changes-edge-cases

Commits on May 20, 2025

Eliminate redundant `tag_change` preload

Eliminate the redundant `tag` preload

Add a `create` match arm for the case when no tag changes were selected

Fix the type error

Add "tags affected" info to the tag revert result flash

To be safe don't change the return type of `Images.batch_update`

Add some type specs to `create_image`

Uninline the `mass_revert_tags` function

Accept [{tag_change_id, tag_id}] in mass_revert_tags`

Use Ecto DSL

Use `principal` terminology in image

Start simple tests for tag changes

Test add/remove combinations

Reduce the data slightly

Refactor

Denest

Move stuff into reusable `snap` functions

More comments

More refactoring in the sake of god of refactoring

Wait for image upload in `create_image` test util

Expose the DB port in docker-compsoe

Add some tests for the tag reverts

Add a test for reverting the change that was later overwritten. Currently probably not the intended behavior?

Add `files` dependency dependency to `app` since test now upload images

Don't revert tag changes that were later overwritten

Add more comments

Better comments

Remove the now-unnecessary uniq_by

Yay, the tag reverts are now taking into account self-cancelling reverts, tests pass

Use `Enum.each()`