lc_geometry propose compute_phases to cover eclipses more heavily#898
Draft
kecnry wants to merge 1 commit intophoebe-project:release-2.5from
Draft
lc_geometry propose compute_phases to cover eclipses more heavily#898kecnry wants to merge 1 commit intophoebe-project:release-2.5from
kecnry wants to merge 1 commit intophoebe-project:release-2.5from
Conversation
|
It is actually an algorithm originally written by Piotr Kołaczek-Szymański (not on GitHub) with some changes. |
Member
Author
|
Ah yes, I'm in the room with new GitHub user @piotrkolaczekszymanski right now 😂 |
Contributor
Wrong, we got him onto github a few days ago! :) |
kecnry
force-pushed
the
lc_geom_compute_phases
branch
from
846020f to
2f30d11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original algorithm written by @piotrkolaczekszymanski and @amiszuda
TODO: