Skip to content

Make into WebExtension compatible with Firefox#180

Open
joallard wants to merge 4 commits intophoebejaffe:masterfrom
joallard:webextension
Open

Make into WebExtension compatible with Firefox#180
joallard wants to merge 4 commits intophoebejaffe:masterfrom
joallard:webextension

Conversation

@joallard
Copy link
Copy Markdown

Follows comments on #168

@phoebejaffe
Copy link
Copy Markdown
Owner

I'm happy to merge this. I'll release the chrome update sometime this weekend, possibly next week (things are a bit hectic), but since it's a small styling change, a slower release shouldn't be a big deal.

@joallard, any other things you're working on for this PR, or is it good to go?

@joallard
Copy link
Copy Markdown
Author

I was trying to remove the dependency on Bower, but I'm not that well versed in js to know what the good practices are in 2017. I had a WIP locally, I'll try to add that and we'll be good to go.

@brenthaas
Copy link
Copy Markdown

brenthaas commented Oct 2, 2017

Any progress on this? I'm looking to contribute as well, and it would be nice to not have the bower dependency if possible

@joallard
Copy link
Copy Markdown
Author

joallard commented Oct 4, 2017

While I agree, I'll leave Bower out of scope for this PR as it pretty much gums up the works. Expect an update to this PR along with a final LGTM. Soon.

@instantgreen
Copy link
Copy Markdown

Any progress?

Since Firefox Quantum got released a few days back I looked into installing this addon through Foxified. The addon tries to upload the okc-plugin to Mozilla but it got rejected due to several problems.

This means I still would like to see this issue be successful...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants