Round corners on Copy icon variants#45
Open
guplem wants to merge 1 commit into
Open
Conversation
Slightly round the corners of all Copy and CopySimple variants (regular, bold, light, thin, duotone, fill) to match Phosphor's softer rounded aesthetic, addressing phosphor-icons/homepage#859. - Stroked variants (regular/bold/light/thin/duotone): add rx="8" to the front rect and convert the back polyline to a path with rounded outer corners; inner concave intersections stay sharp. - Duotone background polygon updated with matching rounded corners. - Fill variants: outer arcs scaled to radius 16 (rx 8 + stroke half 8), matching the convention used by square-fill and credit-card-fill. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Author
|
Hi @rektdeckard this is a small one, I think! Do you think it can be merged? 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slightly round the corners of all
CopyandCopySimplevariants (regular, bold, light, thin, duotone, fill) to match Phosphor's softer rounded aesthetic. Addresses phosphor-icons/homepage#859.What changed
rx="8"to the front rect and convert the back polyline to a path with rounded outer corners. Inner concave intersections stay sharp, matching the rest of Phosphor's design language.copy-fill,copy-simple-fill): outer arcs scaled to radius 16 (rx 8+ stroke half8), following the existing convention used bysquare-fillandcredit-card-fill.12 files changed, 1 line per file. Inner concave corners and stroke widths are preserved.