fix(lib): avoid unnecessary React fragments in JSX output of the icon definition map#141
Open
aleksei-ds wants to merge 2 commits intophosphor-icons:masterfrom
Open
Conversation
added 2 commits
July 12, 2025 14:44
… definition map (/scripts/assemble.ts): Previously, when generating icon weight maps, all SVG JSX content for icon weights was wrapped in a React fragment, even when a single top-level element was present. This update uses JSDOM to parse the SVG content and only adds a fragment when multiple top-level children exist. The result is cleaner and more efficient output that aligns with React's expectations.
aleksei-ds
force-pushed
the
fix/remove-unnecessary-jsx-fragments
branch
from
623f241 to
2c55473
Compare
aleksei-ds
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/scripts/assemble.ts:Previously, when generating icon weight maps, all SVG JSX content for icon weights was wrapped in a React fragment, even when a single top-level element was present.
This update uses JSDOM to parse the SVG content and only adds a fragment when multiple top-level children exist. The result is cleaner and more efficient output that aligns with React's expectations.