make env handling more robust#76
Conversation
|
Hey thanks! I have an example repository at https://github.com/php-actions/example-phpunit that I will make a test for at some point soon. Feel free to create an example usage as a PR on that repo if you can do it before me. |
|
Sure, i will have a look, I need to create a negative test, so I will set an invalid env var, and with the current php-actions/composer@v6, and php-actions/phpunit@v4, this will fail. if i use my forks they will pass. You can see the behaviour here: https://github.com/BradleyGoulding/example-phpunit/actions Do you want me to just open the PR with the test that sets the environment up, pointing to current php-actions/composer@v6, and php-actions/phpunit@master, or wait till you merge the patch and update to include that? My concern is that merging in an intentionally broken test pending the patch, will harm other work. |
|
I have an idea - please create a PR, but I'll merge it into its own branch instead of master, otherwise I agree that things might become a bit confusing. I'll document the branch in the readme to explain what it's testing. Thank you for your work on this. I'm a bit too busy with work projects to be able to pay too much attention to it at the moment. |
|
I have opened the PR php-actions/example-phpunit#15, this adds the workflow that validates this issue. As this impacts multiple repos, let me know if you need me to do anything further. |
This is a potential fix for #75
It filters the --env-file process to ensure it only passes valid formatted env values