Preserve transparency when pasting with alpha on the Imagick driver#878
Merged
mlocati merged 2 commits intoJun 3, 2026
Merged
Conversation
Collaborator
|
👍 |
Contributor
Author
|
Thank you @mlocati! |
Collaborator
|
Thanks to you for these fixes and related tests! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
paste()with an alpha < 100 on the Imagick driver paints a "black box" over the transparent areas of the pasted image. Paste a watermark that has a transparent surround at, say, 50% opacity and the whole bounding box comes back as a semi-opaque dark rectangle instead of just the visible part fading.Culprit is
setImageAlpha($alpha / 100)(and thesetImageOpacityfallback). Both set every pixel's alpha to the same value, so fully-transparent pixels turn semi-opaque. GD doesn't have this problem becauseimagecopymergeblends without flattening the source alpha.The fix scales the existing alpha instead of overwriting it:
evaluateImage(EVALUATE_MULTIPLY, $alpha / 100, CHANNEL_ALPHA), after activating the alpha channel. Transparent stays transparent, opaque fades.