Conversation
Updated php version
Updated PHP version matrix
Updated composer.json to support php8.5
Updated Composer Json with PHP 85
Closed
Updated the composer for eloquent/liberator
Updated related versions
mvorisek
reviewed
Jan 24, 2026
.github/workflow.yml
Outdated
| @@ -0,0 +1,157 @@ | |||
| name: Unit | |||
Member
There was a problem hiding this comment.
why is this workflow file added/duplicated?
Author
There was a problem hiding this comment.
I deleted newly created Workflow
mvorisek
reviewed
Jan 24, 2026
composer.json
Outdated
| "phpunit/phpunit": "^9.5.25 || ^10.0 || ^11.0", | ||
| "predis/predis": "^1.1.8 || ^2.0", | ||
| "spatie/async": "^1.5" | ||
| "spatie/async": "^1.5 || ^1.8" |
composer.json src/Mutex/DistributedMutex.php
…ce TestAccess for property access
…perty/method access
…support PHP 8.2 and above
Added explicit handling for NaN and infinities in formatTimeout method.
mvorisek
reviewed
Jan 30, 2026
| "ext-pdo_sqlite": "*", | ||
| "ext-redis": "*", | ||
| "ext-sysvsem": "*", | ||
| "eloquent/liberator": "^2.0 || ^3.0", |
Member
There was a problem hiding this comment.
I like this change. Please send it as an extra PR.
Then this PR for PHP 8.5 would be hugely simplified and much more readable.
Author
There was a problem hiding this comment.
can you please help me with a method popsValue this is not defined anywhere. Calling this method is failing the testcases. @mvorisek
Member
There was a problem hiding this comment.
See https://github.com/search?q=repo%3Aeloquent%2Fpops%20popsvalue&type=code , it is part of eloquent/pops package.
…e parameter consistency
…otations, and update TestAccess invocation for consistency
…properties and improve strategy assignment consistency
…ions for improved clarity
…emove redundant annotations
… improved type clarity
mvorisek
reviewed
Feb 2, 2026
| * @param \Closure(float): Mutex $mutexFactory | ||
| * @param \Closure(): void $setUp | ||
| * | ||
| * @dataProvider provideHighContentionCases |
Member
There was a problem hiding this comment.
You need to keep these annotations for PHP 7.4...
…ndant annotations, and clean up imports
…e` for compatibility across PHPUnit versions and clean up imports
…estAccess` usage across multiple test cases
…ie/async patch 8.0+ compatibility
…ie/async patch 8.0+ compatibility
…ie/async patch 8.0+ compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #81