-
Notifications
You must be signed in to change notification settings - Fork 25
GH Actions: change PHAR building to reusable workflow #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+56
−88
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| name: Build Binary | ||
|
|
||
| on: | ||
| workflow_call: | ||
|
|
||
| jobs: | ||
| bundle: | ||
| name: Build binary | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v6 | ||
|
|
||
| - name: Setup PHP | ||
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: 8.2 | ||
| extensions: exif, phar, openssl, sodium | ||
| coverage: none | ||
| ini-values: phar.readonly=Off, error_reporting=-1, display_errors=On, display_startup_errors=On, zend.assertions=1 | ||
| # Autoload files generated with Composer 2.3 are not compatible with PHP < 7.0. | ||
| tools: composer:2.2 | ||
| env: | ||
| fail-fast: true | ||
|
|
||
| - name: Install Composer dependencies | ||
| uses: ramsey/composer-install@v3 | ||
| with: | ||
| composer-options: "--no-dev" | ||
| # Bust the cache at least once a month - output format: YYYY-MM. | ||
| custom-cache-suffix: $(date -u "+%Y-%m") | ||
|
|
||
| # Note: do NOT turn on the requirement checker in the box config as it is no longer | ||
| # compatible with PHP < 7.2. | ||
| - name: Install Box | ||
| run: wget https://github.com/box-project/box/releases/latest/download/box.phar -O box.phar && chmod 0755 box.phar && pwd | ||
|
|
||
| - name: Validate configuration | ||
| run: php box.phar validate -i box.json | ||
|
|
||
| - name: Building binary... | ||
| run: php box.phar compile -v --config=box.json | ||
|
|
||
| - name: Show info about the build phar with box-project/box | ||
| run: php box.phar info -l parallel-lint.phar | ||
|
|
||
| - name: Upload PHAR to workflow summary | ||
| uses: actions/upload-artifact@v6 | ||
| with: | ||
| name: parallel-lint-phar | ||
| path: ./parallel-lint.phar | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
side-note: might be worth caching it.
You could check
https://github.com/box-project/box/releases/latestfor which the header location gives the tag (e.g.https://github.com/box-project/box/releases/tag/4.6.10) and use that version as the cache keyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theofidry Good point! I'll open an issue as a reminder to look into this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#200