Skip to content

Fix: force the use of colors when the '--colors' flag is supplied.#190

Open
esthezia wants to merge 2 commits intophp-parallel-lint:developfrom
esthezia:develop
Open

Fix: force the use of colors when the '--colors' flag is supplied.#190
esthezia wants to merge 2 commits intophp-parallel-lint:developfrom
esthezia:develop

Conversation

@esthezia
Copy link
Copy Markdown

When the php-parallel-lint command is ran as a subcommand, and the --colors flag is used, it is not honoured. This fixes this, and allows for coloured output when forced.

@jrfnl
Copy link
Copy Markdown
Collaborator

jrfnl commented Mar 6, 2026

@esthezia Thank you for your interest in contributing to this repo.

Would you mind adding a test covering the change to this PR ?

@jrfnl jrfnl added the Type: bug label Mar 6, 2026
@esthezia
Copy link
Copy Markdown
Author

esthezia commented Mar 6, 2026

Unfortunately, I'm not able to do that. Can you, please, help me with this piece?

Thank you!

@jrfnl
Copy link
Copy Markdown
Collaborator

jrfnl commented Mar 6, 2026

Unfortunately, I'm not able to do that. Can you, please, help me with this piece?

@esthezia What information do you need to allow you to add the test(s) ?

@esthezia
Copy link
Copy Markdown
Author

@jrfnl The codebase is very new to me, and it is not within the scope of my intetest to get to know it, unfortunately. I discovered how to fix this bug because it was easy, and did not have to dig through the code so much. But other than that, I am not interested in doing, and can't, at the moment. But I would hate to not have this fixed for a missing test -- if you, or someone else, can help with the test, it would be very helpful, as we can get this working for a lot of people!

Thank you! Respectfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants