Update PHP8 appreciate for new workshop version#49
Open
AydinHassan wants to merge 8 commits intomasterfrom
Open
Update PHP8 appreciate for new workshop version#49AydinHassan wants to merge 8 commits intomasterfrom
AydinHassan wants to merge 8 commits intomasterfrom
Conversation
AydinHassan
force-pushed
the
workshop-rewrite
branch
from
dcce570 to
d200dbb
Compare
AydinHassan
force-pushed
the
workshop-rewrite
branch
from
f9a85f6 to
f435075
Compare
Member
Author
|
@mikeymike only a few failures 😱 the fix for the big issue with bind mounts was this: https://github.com/php-school/php-workshop/pull/300/files#diff-b8aa8129dc6b9ec2a602a608dfce32dfecafdfb0e1579d49cfb79076ffbc8521L60 - no idea why, I just randomly commented it out and it started working. Locally I have 2 failures and it seems like a timing issue because when I run the failing ones on it's own it works fine. But we pretty close now! |
Member
Author
|
The two failures on |
AydinHassan
force-pushed
the
workshop-rewrite
branch
from
8f47449 to
397bcbe
Compare
AydinHassan
force-pushed
the
workshop-rewrite
branch
from
ad3b81f to
1dc4d4a
Compare
AydinHassan
force-pushed
the
workshop-rewrite
branch
from
75ef338 to
8bcd69b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.