Move the blocking check to the read method.#17
Open
tbannister wants to merge 1 commit intophp-school:masterfrom
Open
Move the blocking check to the read method.#17tbannister wants to merge 1 commit intophp-school:masterfrom
tbannister wants to merge 1 commit intophp-school:masterfrom
Conversation
Move the stream_get_meta_data check into the read function to always restore the original status. Also to prevent unnecessary looping/screen flicker, turn blocking off only when there is data in the internal stream buffer.
Author
|
The __destruct call wasn't always restoring the blocking status in practice, so I've changed the approach, and it should now both fix the pasting issue and leave the blocking status unchanged. Technically we're not supposed to use unread_bytes to check for more data, but that appears to be exactly what we need to be checking to handle the paste situation. The problem isn't waiting for more data to be read from input, it's forcing the buffered data to be handled without waiting for new input. |
Member
|
Sorry @tbannister I missed this - is it still needed? If so, could you maybe rebase? |
|
Thank you @tbannister That actually solved the bug the I had with the redraw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the stream_get_meta_data check into the read function to always restore the original status.
Also to prevent unnecessary looping/screen flicker, turn blocking off only when there is data in the internal stream buffer.