Chore: Fix completion permissions#299
Merged
Merged
Conversation
Remove the executable bit from the completion file: it is sourced and should never have been executable. The globbetyglob()/make_scripts_executable() functions, introduced in ae7bebe ("Add autoconf && ./configure && make test_xml replacement", 2007-09-08), are no longer needed. Executable bits are now managed by version control, so the functions are removed as well.
Member
|
From what I can see this looks good to me. But it's good if @alfsb can take a final look. |
alfsb
approved these changes
Jun 13, 2026
alfsb
left a comment
alfsb
left a comment
Member
There was a problem hiding this comment.
I never used these .sh scripts like this, but always considered having a dynamic changing of executable permitions a security risk. Better be safe than sorry. If anyone complains, then we see how to fix this old usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the executable bit from the completion file: it is sourced and should never have been executable.
The globbetyglob()/make_scripts_executable() functions, introduced in ae7bebe ("Add autoconf && ./configure && make test_xml replacement", 2007-09-08), are no longer needed. Executable bits are now managed by version control, so the functions are removed as well.