[Sync EN] Major rewrite of the setcookie reference page#252
Merged
Conversation
Brings reference/network/functions/setcookie.xml up to date with
the upstream rewrite (EN-Revision 6122a8317ca0068fc71f6a5167e0a2d99166ec7c):
- Most inline <para> blocks converted to <simpara> (mirror EN).
- Description and notes rephrased to impersonal/factual style
("in the script", "this function is called") instead of the
old "your script"/"you place calls to" phrasing.
- options parameter: new <note> about samesite="None" requiring
secure=true, ValueError from PHP 8.0.0 onward.
- New <refsect1 role="errors"> section: E_WARNING before PHP 8.0.0,
ValueError as of PHP 8.0.0 for unknown options.
- Changelog: new 8.0.0 row, structural simpara cleanups.
- Examples reworked: new intro about browser developer tools
(Storage/Application tab), German code comments in the send
example, two short <simpara>s for the delete example, refreshed
Array von Cookies wording.
- Common Pitfalls bullet 4 updated: browser stores separate cookies
for each path/domain, json_encode/json_decode instead of explode.
- Output-buffering note rewritten in impersonal form.
- See-also block: wrapping <para> dropped.
- Obsolete <!-- $Revision$ --> SVN marker dropped.
Existing Maintainer (sammywg) and Reviewed: yes / Rev-Revision kept.
msamesch
reviewed
Jun 12, 2026
msamesch
reviewed
Jun 12, 2026
msamesch
reviewed
Jun 12, 2026
msamesch
reviewed
Jun 12, 2026
msamesch
reviewed
Jun 12, 2026
msamesch
reviewed
Jun 12, 2026
msamesch
reviewed
Jun 12, 2026
msamesch
approved these changes
Jun 12, 2026
msamesch
left a comment
msamesch
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot, looks good to me! Just a bit of nitpicking..
Co-authored-by: Martin Samesch <samesch@php.net>
Co-authored-by: Martin Samesch <samesch@php.net>
Co-authored-by: Martin Samesch <samesch@php.net>
Co-authored-by: Martin Samesch <samesch@php.net>
Co-authored-by: Martin Samesch <samesch@php.net>
Co-authored-by: Martin Samesch <samesch@php.net>
Co-authored-by: Martin Samesch <samesch@php.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync
reference/network/functions/setcookie.xmlwith upstream6122a8317c. Most inline<para>switched to<simpara>, prose moved to impersonal style, new errors section (E_WARNINGbefore PHP 8.0.0,ValueErroras of 8.0.0 for unrecognisedoptionskeys) and the matching changelog row, plus thesamesite="None"requiressecure=truenote. Examples and common pitfalls refreshed. MaintainersammywgandReviewed: yeskept.