Skip to content

Fix GH-19730: undefined behavior in gd_interpolation.c. #22149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devnexen wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from
+48 −5
Open

Fix GH-19730: undefined behavior in gd_interpolation.c. #22149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions ext/gd/libgd/gd_interpolation.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
#include <stdlib.h>
#include <string.h>
#include <math.h>
#include <limits.h>

#include "gd.h"
#include "gdhelpers.h"
Expand Down Expand Up @@ -2245,7 +2246,10 @@ int gdTransformAffineGetImage(gdImagePtr *dst,
src_area = &area_full;
}

gdTransformAffineBoundingBox(src_area, affine, &bbox);
if (gdTransformAffineBoundingBox(src_area, affine, &bbox) != GD_TRUE) {
*dst = NULL;
return GD_FALSE;
}

*dst = gdImageCreateTrueColor(bbox.width, bbox.height);
if (*dst == NULL) {
Expand Down Expand Up @@ -2421,6 +2425,8 @@ int gdTransformAffineCopy(gdImagePtr dst,
int gdTransformAffineBoundingBox(gdRectPtr src, const double affine[6], gdRectPtr bbox)
{
gdPointF extent[4], min, max, point;
double width, height;
int bbox_x, bbox_y, bbox_width, bbox_height;
int i;

extent[0].x=0.0;
Expand Down Expand Up @@ -2451,10 +2457,29 @@ int gdTransformAffineBoundingBox(gdRectPtr src, const double affine[6], gdRectPt
if (max.y < extent[i].y)
max.y=extent[i].y;
}
bbox->x = (int) min.x;
bbox->y = (int) min.y;
bbox->width = (int) floor(max.x - min.x) - 1;
bbox->height = (int) floor(max.y - min.y);
width = floor(max.x - min.x);
height = floor(max.y - min.y);
if (!isfinite(min.x) || !isfinite(min.y) || !isfinite(width) || !isfinite(height)
|| min.x <= INT_MIN || min.x > INT_MAX
|| min.y <= INT_MIN || min.y > INT_MAX
|| width < 1.0 || width > INT_MAX
|| height < 0.0 || height > INT_MAX) {
return GD_FALSE;
}
bbox_x = (int) min.x;
bbox_y = (int) min.y;
bbox_width = (int) width - 1;
bbox_height = (int) height;
if ((bbox_x < 0 && bbox_width > INT_MAX + bbox_x)
|| (bbox_x > 0 && bbox_width > INT_MAX - bbox_x)
|| (bbox_y < 0 && bbox_height > INT_MAX + bbox_y)
|| (bbox_y > 0 && bbox_height > INT_MAX - bbox_y)) {
return GD_FALSE;
}
bbox->x = bbox_x;
bbox->y = bbox_y;
bbox->width = bbox_width;
bbox->height = bbox_height;
return GD_TRUE;
}

Expand Down
18 changes: 18 additions & 0 deletions ext/gd/tests/gh19730.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
--TEST--
GH-19730 (undefined behavior in gd_interpolation.c)
--EXTENSIONS--
gd
--SKIPIF--
<?php
if (!GD_BUNDLED) {
die("skip meaningful only for bundled libgd\n");
}
?>
--FILE--
<?php
$im = imagecreatetruecolor(8, 8);
$affine = [1211472000, 1, 1, 1, 1, 1];
var_dump(imageaffine($im, $affine));
?>
--EXPECT--
bool(false)
Loading