streams: use C enums instead of define for error_{store_}mode - #22901
Merged
Conversation
Also make private as these are not used outside of the file
TimWolla
approved these changes
Jul 27, 2026
TimWolla
left a comment
TimWolla
left a comment
Member
There was a problem hiding this comment.
Looks correct except for nit. I didn't check if this is used as a bit set anywhere, but it seems not based on the enum values. I also didn't check if you caught all usages.
Member
Author
|
I've checked via git grep that all usages are within the file. And no those are not use as bitmasks. |
Girgias
marked this pull request as ready for review
July 27, 2026 19:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also make private as these are not used outside of the file.
Split from #22847