Skip to content

Fix variable naming in IsTraitTest from $isFinal to $isTrait #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fain182 merged 1 commit into from
Mar 29, 2026
Merged

Fix variable naming in IsTraitTest from $isFinal to $isTrait #604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/Unit/Expressions/ForClasses/IsTraitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,26 +13,26 @@ class IsTraitTest extends TestCase
{
public function test_it_should_return_violation_error(): void
{
$isFinal = new IsTrait();
$isTrait = new IsTrait();

$classDescription = (new ClassDescriptionBuilder())
->setFilePath('src/Foo.php')
->setClassName('HappyIsland')
->build();

$because = 'we want to add this rule for our software';
$violationError = $isFinal->describe($classDescription, $because)->toString();
$violationError = $isTrait->describe($classDescription, $because)->toString();

$violations = new Violations();
$isFinal->evaluate($classDescription, $violations, $because);
$isTrait->evaluate($classDescription, $violations, $because);

self::assertNotEquals(0, $violations->count());
self::assertEquals('HappyIsland should be trait because we want to add this rule for our software', $violationError);
}

public function test_it_should_return_true_if_is_trait(): void
{
$isFinal = new IsTrait();
$isTrait = new IsTrait();

$classDescription = (new ClassDescriptionBuilder())
->setFilePath('src/Foo.php')
Expand All @@ -42,7 +42,7 @@ public function test_it_should_return_true_if_is_trait(): void

$because = 'we want to add this rule for our software';
$violations = new Violations();
$isFinal->evaluate($classDescription, $violations, $because);
$isTrait->evaluate($classDescription, $violations, $because);

self::assertEquals(0, $violations->count());
}
Expand Down
Loading