chore(ci): drop SSH key step and modernize workflows#15
Merged
Conversation
1e2398c to
5644a63
Compare
CI on main has been failing since #11 because the SSH_PRIVATE_KEY secret used by the workflows can't be loaded ("Error loading key: error in libcrypto"). The SSH dance was originally for pulling private git dependencies via Composer — all phpnomad packages are public on Packagist now, so the dance isn't needed. Replace the SSH key/known-hosts/agent steps with shivammathur/setup-php plus a vanilla `composer install`. Same outcome, no secrets required, runs on forks. Also: - Add `pull_request` triggers so PRs run CI - Bump actions/checkout to v4 - Add `fail-fast: false` so a failure on one PHP version doesn't hide results from the others - Extend the PHPUnit matrix to include 8.3 - Move PHPStan to a sensible PHP runtime (8.2) while keeping `php_version: 7.4` for the analysis target - Bump the spellcheck checkout from `@master` to `@v4`
5644a63 to
8ca32ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on `main` has been failing since #11 (April) for several reasons stacked on top of each other. This PR addresses the workflow-level issues so PRs can actually run CI again. To get the runs fully green the absolute-minimum library-code touches are included too — there's a much larger PHPStan level 9 cleanup that's deliberately out of scope.
What was broken
What this changes
Workflows
Spellcheck wordlist
Library code (real bugs, minimum needed to pass level 5)
Why merge this first
Two open PRs (#13, #14) are bug fixes blocked by this same CI failure. Once this lands they should go green automatically.
Follow-up work (separate PRs)