Add facility for depth-based indentation of messages and key/value pairs#19
Add facility for depth-based indentation of messages and key/value pairs#19madkins23 wants to merge 3 commits intophsym:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
- Coverage 98.83% 94.28% -4.55%
==========================================
Files 5 5
Lines 429 455 +26
==========================================
+ Hits 424 429 +5
- Misses 4 25 +21
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
I've been thinking about this and I could probably "fix" the thread safety issue by:
This is actually what I originally intended to do, but there's no way to access the key/value pairs except by looping through them. This didn't immediately seem like a good idea. That's when I created the new interface and so forth. Providing the depth argument in the key/value pairs would sort of kick the thread safety issue back to the calling code at the cost of iterating through the pairs twice (though only for handlers that set indentation in the options). I may create another branch and try this out. Later. Maybe much later. 😉 |
|
The alternate version desccribed above is in #20. |
I honestly don't expect this PR to be accepted. I'm pretty sure I'm the only person who thinks this is useful. Plus it's not thread safe. Fortunately for me, I have my own fork to play with so I can cope with the rejection. 😞
A description of what this is supposed to do (with an example) is in the adjusted
README.