fix: resolve ReferenceError cutoff is not defined in applyFilter#110
Open
Fruhji wants to merge 1 commit into
Open
fix: resolve ReferenceError cutoff is not defined in applyFilter#110Fruhji wants to merge 1 commit into
Fruhji wants to merge 1 commit into
Conversation
The hourly_by_model filter in applyFilter() still referenced the old
"cutoff" variable after the function was refactored to use { start, end }
from getRangeBounds(). This caused a ReferenceError on every filter call,
preventing any data from being displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After opening the dashboard, no data was displayed and the browser console showed:
Root cause
The
hourly_by_modelfilter insideapplyFilter()still referenced the oldcutoffvariable, which was removed when the function was refactored to use{ start, end }fromgetRangeBounds(). All other filters in the same function already usedstart/endcorrectly.Fix
Replace the stale
cutoffreference withstartandendto match the existing pattern used forfilteredDailyandfilteredSessions.