fix: HTTP router 404 on query params + missing first_timestamp in incremental scan#111
Open
Fruhji wants to merge 2 commits into
Open
fix: HTTP router 404 on query params + missing first_timestamp in incremental scan#111Fruhji wants to merge 2 commits into
Fruhji wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
1. Dashboard returns 404 when URL has query parameters
Opening
http://localhost:8080/?range=month&models=claude-sonnet-4-6returned a 404 becausedo_GETcomparedself.pathdirectly against"/". When the browser appends query parameters,self.pathbecomes/?range=...which never matched.Fix: Parse the path with
urlparsebefore routing so query parameters are stripped.2.
first_timestampnever updated in incremental scansWhen new lines are appended to an existing JSONL file, the incremental scan updated
last_timestampcorrectly but never updatedfirst_timestamp— even if a newly seen record had an earlier timestamp. This caused session duration (duration_min) to be underestimated.Fix: Mirror the
last_timestampupdate logic forfirst_timestampusing<instead of>.