fix: use start/end bounds in hourly filter instead of undefined cutoff#121
Closed
tswicegood wants to merge 1 commit into
Closed
fix: use start/end bounds in hourly filter instead of undefined cutoff#121tswicegood wants to merge 1 commit into
tswicegood wants to merge 1 commit into
Conversation
The hourly aggregation filter referenced a `cutoff` variable that doesn't exist in scope, throwing "ReferenceError: cutoff is not defined" on dashboard load. Switch to the same `start`/`end` bounds the daily filter uses (from getRangeBounds(selectedRange)) so hourly data is range-filtered consistently. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Author
|
Just realized this is a duplicate of #117. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dashboard throws a JS error on every load:
The hourly aggregation filter in
applyFilter()references acutoffvariable that doesn't exist in scope — it looks like a leftover from an earlier iteration. The surrounding daily/sessions filters usestart/endfromgetRangeBounds(selectedRange). This PR switches the hourly filter to the same bounds so it matches the rest of the code and the error goes away.dashboard.pyTest plan
🤖 Generated with Claude Code