Issue #151 Ignored push to contributors in "Update Contributors" Action file#207
Merged
Merged
Conversation
Owner
|
Oh what a issue lol, thank you so much to fix this |
Contributor
Author
|
@all-contributors add @GigaWHATT for code |
Contributor
|
I've put up a pull request to add @GigaWHATT! 🎉 |
Contributor
Author
Yes it wasn't a big issue at all, but you gotta start somewhere! |
Collaborator
|
@all-contributors add @GigaWHATT for code |
Contributor
|
@GigaWHATT already contributed before to code |
Contributor
Author
Maybe I should add myself manually. |
Contributor
|
@GigaWHATT already contributed before to code |
Owner
|
🎉 This PR is included in version 3.25.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📘 Pull Request Template – PhysicsHub
Thank you for contributing to PhysicsHub!
Please complete the sections below to help us review your pull request efficiently.
🔍 Description
In response to issue #151, I added a line to the contributors.yaml file, such that the action would not trigger upon push onto the contributors list. This previously led to an infinite request loop, hence the maximum requests error.
Closes #ISSUE_151 (if applicable)
✅ Checklist
Before requesting a review, please ensure that you have:
npm run dev)🎨 Visual Changes (if UI-related)
📂 Type of Change
🧩 Additional Notes for Reviewers
This is my first contribution to the project, so feel free to tell me if it doesn't work.