Skip to content

Issue #151 Ignored push to contributors in "Update Contributors" Action file#207

Merged
physicshub merged 3 commits into
physicshub:mainfrom
GigaWHATT:contributors_request_fix
Feb 26, 2026
Merged

Issue #151 Ignored push to contributors in "Update Contributors" Action file#207
physicshub merged 3 commits into
physicshub:mainfrom
GigaWHATT:contributors_request_fix

Conversation

@GigaWHATT
Copy link
Copy Markdown
Contributor

📘 Pull Request Template – PhysicsHub

Thank you for contributing to PhysicsHub!
Please complete the sections below to help us review your pull request efficiently.


🔍 Description

In response to issue #151, I added a line to the contributors.yaml file, such that the action would not trigger upon push onto the contributors list. This previously led to an infinite request loop, hence the maximum requests error.

Closes #ISSUE_151 (if applicable)


✅ Checklist

Before requesting a review, please ensure that you have:

  • Verified that the project builds and runs locally (npm run dev)
  • Ensured no ESLint or TypeScript warnings/errors remain
  • Updated documentation, comments, or in-code explanations where needed
  • Verified responsiveness across devices (desktop, tablet, mobile)
  • Followed the CONTRIBUTING.md guidelines

🎨 Visual Changes (if UI-related)

image

📂 Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📝 Documentation update
  • ♻️ Refactor / code quality improvement
  • 🎨 UI/UX enhancement
  • 🔒 Security improvement

🧩 Additional Notes for Reviewers

This is my first contribution to the project, so feel free to tell me if it doesn't work.

@physicshub
Copy link
Copy Markdown
Owner

Oh what a issue lol, thank you so much to fix this

@physicshub physicshub merged commit 378d580 into physicshub:main Feb 26, 2026
1 check passed
@GigaWHATT
Copy link
Copy Markdown
Contributor Author

@all-contributors add @GigaWHATT for code

@allcontributors
Copy link
Copy Markdown
Contributor

@GigaWHATT

I've put up a pull request to add @GigaWHATT! 🎉

@GigaWHATT
Copy link
Copy Markdown
Contributor Author

Oh what a issue lol, thank you so much to fix this

Yes it wasn't a big issue at all, but you gotta start somewhere!

@mattqdev
Copy link
Copy Markdown
Collaborator

@all-contributors add @GigaWHATT for code

@allcontributors
Copy link
Copy Markdown
Contributor

@mattqdev

@GigaWHATT already contributed before to code

@GigaWHATT
Copy link
Copy Markdown
Contributor Author

@all-contributors add @GigaWHATT for code

Maybe I should add myself manually.

@allcontributors
Copy link
Copy Markdown
Contributor

@GigaWHATT

@GigaWHATT already contributed before to code

@physicshub
Copy link
Copy Markdown
Owner

🎉 This PR is included in version 3.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants