Skip to content

fix: simplify footer quick links styling #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhijeetnardele24-hash wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: simplify footer quick links styling #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions app/(core)/components/Footer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,19 +49,21 @@ function Footer() {
</p>
</div>
<div className="footer-section footer-links">
<h3 className="footer-center">Quick Links</h3>
<h3>Quick Links</h3>
<ul>
{links.map(({ to, label }) => (
<li key={to}>
<div className="footer-links-dot" />
<Link href={to}>{label}</Link>
</li>
))}
<li>
<div className="footer-links-dot" />
<a onClick={openFeedback} style={{ cursor: "pointer" }}>
<button
type="button"
className="footer-feedback-link"
onClick={openFeedback}
>
Leave Feedback
</a>
</button>
</li>
</ul>
</div>
Expand Down
45 changes: 21 additions & 24 deletions app/(core)/styles/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -953,45 +953,42 @@ footer {
padding: 0;
display: flex;
flex-direction: column;
align-items: center;
align-items: flex-start;
}

.footer-links li {
margin-bottom: 0.5rem;
position: relative;
width: 100%;
}

.footer-links li::before {
content: "";
position: absolute;
left: -1.2rem;
top: 50%;
transform: translateY(-50%);
width: 0.7em;
height: 0.7em;
border-radius: 50%;
transition:
box-shadow 0.3s,
background 0.3s;
.footer-links h3 {
justify-content: flex-start;
text-align: left;
}

.footer-links a {
color: var(--accent-color);
.footer-links a,
.footer-feedback-link {
color: var(--text-color);
background: none;
border: 0;
padding: 0;
font: inherit;
text-align: left;
transition:
color 0.3s,
text-shadow 0.3s;
text-shadow 0.3s,
box-shadow 0.3s;
Comment on lines 977 to +980
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

box-shadow is included in the transition list and explicitly set to none on hover for footer quick links, but no footer link styles ever apply a non-none box-shadow (and the global a:hover glow is via text-shadow). Consider removing box-shadow from both the transition and hover override so the hover feedback stays focused on a simple color change (plus the necessary text-shadow: none override).

Copilot uses AI. Check for mistakes.
}

.footer-links a:hover {
.footer-links a:hover,
.footer-feedback-link:hover {
color: var(--accent-color);
text-shadow: 0 0 6px var(--accent-color);
box-shadow: 0 0 0px var(--accent-color);
text-shadow: none;
box-shadow: none;
}

.footer-links li:hover::before,
.footer-links a:hover ~ li::before {
background: var(--accent-color);
box-shadow: 0 0 8px var(--accent-color);
.footer-feedback-link {
cursor: pointer;
}

.footer-center {
Expand Down
Loading