Skip to content

Fix/potential energy reference height #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattqdev merged 2 commits into from
May 16, 2026
+5 −3
Merged

Fix/potential energy reference height #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
870b82a
fix: show correct unit for acceleration vector label in BallAcceleration
TechGenius-Karan May 16, 2026
dd3cf97
fix: use correct reference height for potential energy in BallGravity
TechGenius-Karan May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/(core)/physics/ForceRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ export class ForceRenderer {

let labelText = text;
if (showMag && magnitude !== undefined) {
labelText = `${text} (${magnitude.toFixed(1)}N)`;
const unit = options.unit ?? "N";
labelText = `${text} (${magnitude.toFixed(1)}${unit})`;
}

p.push();
Expand Down
3 changes: 2 additions & 1 deletion simulations/BallAcceleration.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,8 @@ export default function BallAcceleration() {
accelerationForce.x / bodyRef.current.params.mass,
-(accelerationForce.y / bodyRef.current.params.mass),
"#ef4444",
"Acceleration"
"Acceleration",
{ unit: "m/s²" }
);
}

Expand Down
2 changes: 1 addition & 1 deletion simulations/BallGravity.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ export default function BallGravity() {
kineticEnergy: bodyRef.current.getKineticEnergy(),
potentialEnergy: bodyRef.current.getPotentialEnergy(
gravity,
toMeters(p.height)
size / 2
),
},
{
Expand Down
Loading