fix: show height above lowest point in SimplePendulum info panel#324
Merged
mattqdev merged 1 commit intoMay 22, 2026
Merged
Conversation
The Height field in the info panel was displaying -position.y, which is the negated Y-up physics coordinate. Since the anchor sits high up in physics space, this always showed a large negative number unrelated to the pendulum's actual swing height. Fix: compute height as position.y - (anchor.y - length), which gives the height above the bob's lowest point (equilibrium). This reads 0 m at rest and increases correctly as the bob swings up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📘 Pull Request Template – PhysicsHub
Thank you for contributing to PhysicsHub!
Please complete the sections below to help us review your pull request efficiently.
🔍 Description
What was wrong
The Height field in the Simple Pendulum info panel was always showing a large negative number (e.g.
-2.4 m), even when the pendulum was just hanging still. This happened because the code was using-position.ytocalculate height.
The problem: the simulation uses a Y-up coordinate system where the anchor point sits at a large positive Y
value (90% of the canvas height in meters). So negating the bob's Y position doesn't give a meaningful height —
it gives a big negative number that doesn't relate to the pendulum's swing at all.
What the fix does
Height is now calculated as the bob's height above its lowest point (the equilibrium position at the bottom
of the swing):
0.00 m✓Closes #5 (if applicable)
✅ Checklist
Before requesting a review, please ensure that you have:
npm run dev)🎨 Visual Changes (if UI-related)
IF CHANGES ARE RELATED TO SIMULATIONS PLEASE SEND A SHORT CLIP ABOUT IT
(OBLIGATORY)
📂 Type of Change
🧩 Additional Notes for Reviewers