fix: restore getTimeScale() in VectorsOperations so physics body moves#325
Merged
mattqdev merged 1 commit intoMay 22, 2026
Conversation
The physics accumulator was multiplied by a hardcoded scale of 0, so worldRef.current.step() was never called and the Planck.js body was permanently frozen regardless of the physicsEnabled toggle. Restored the getTimeScale() call and added it to the Time.js imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📘 Pull Request Template – PhysicsHub
Thank you for contributing to PhysicsHub!
Please complete the sections below to help us review your pull request efficiently.
🔍 Description
What was wrong
When physicsEnabled is turned on in the Vector Operations simulation, a physics ball is supposed to appear and move
around the canvas responding to forces. It showed up on screen but was completely frozen — no movement at all.
The cause: a debug leftover on one line:
const scale = 0; //getTimeScale();
The physics accumulator was being multiplied by 0 every frame, so the Planck.js world was never stepped forward, and
the ball never moved.
Fix
Restored the original getTimeScale() call and added it to the imports from Time.js:
const scale = getTimeScale(); // was: const scale = 0;
Closes #BUG-003 (if applicable)
✅ Checklist
Before requesting a review, please ensure that you have:
npm run dev)🎨 Visual Changes (if UI-related)
IF CHANGES ARE RELATED TO SIMULATIONS PLEASE SEND A SHORT CLIP ABOUT IT
(OBLIGATORY)
📂 Type of Change
🧩 Additional Notes for Reviewers