Skip to content

Scalafmt basic setup#98

Open
Helw150 wants to merge 3 commits intopicnicml:masterfrom
Helw150:will/scalafmt
Open

Scalafmt basic setup#98
Helw150 wants to merge 3 commits intopicnicml:masterfrom
Helw150:will/scalafmt

Conversation

@Helw150
Copy link

@Helw150 Helw150 commented Sep 27, 2019

Description of Changes

Adds Basic Scalafmt support via SBT

Adds basic support for #95

Includes
  • Code changes
  • Tests
  • Documentation

@Helw150
Copy link
Author

Helw150 commented Sep 27, 2019

@inejc Here's my personal setup for Scalafmt - feel free to make changes as you please (If you'd like I can also add a format of the whole project to this PR so you can see what these settings would do)

Copy link
Member

@inejc inejc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Yeah, let's try to do full formatting and we can readjust the config if needed later.

.scalafmt.conf Outdated
@@ -0,0 +1,21 @@
version=2.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably version = 2.0.0?

@Helw150
Copy link
Author

Helw150 commented Oct 8, 2019

@inejc Finally had a bit of free time, here's what Scalafmt does to everything

@picnicml picnicml deleted a comment Oct 8, 2019
@inejc
Copy link
Member

inejc commented Oct 8, 2019

@Helw150 this is really cool, I like it. We have a pretty big PR waiting to be merged (#107) and in light of avoiding complex conflicts, I suggest we wait with this one and run Scalafmt again once #107 is merged. Would that work for you?

@inejc
Copy link
Member

inejc commented Oct 8, 2019

Ok so after a discussion with @matejklemen, we want to:

@Helw150
Copy link
Author

Helw150 commented Oct 8, 2019

Yup, easy enough for me to wait and run the format after that gets merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants