Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mountaineer equivalent of piercefreeman/iceaxe#104. This allows clients to pass through custom primitive-types (like CustomUUID) that allows for more structured typehinting.
For now we generate the parent-level underlying type in the frontend (ie.
stringinstead of actuallyCustomUUID). We could generate typescript type definitions that mirror the specificity of the server components, but this would mean additional work for clients to pass-in client side values (some explicit type cast or otherwise). Since most server values are just used as-is we prefer to leave this ambiguity.