Conversation
Coverage Report
Compared to |
piercefreeman
approved these changes
Mar 26, 2026
MOZGIII
commented
Mar 26, 2026
a1a5244 to
7370e31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a part of the work towards the workers refactor; it introduces a crate for managed processes which is to be used in the worker pools.
This is a concise building block that encapsulates the behaviors of a process that needs to behave in a suitable-fro-the-process-pool manner: it has to terminate when we exit, even if we got
SIGKILL-ed and are unable to gracefully terminate the process pool.This crate is not used just yet, but the plan is to build new set of concise crates on top of it, and eventually replace the
waymark-remotecrate. For a preview of the full picture check out this PR: #278.