Draft
Conversation
6e2bde6 to
97c110d
Compare
02b709a to
53f4216
Compare
Coverage Report
Compared to |
b3e9ce9 to
14aec6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to make the work I've been doing on the replay feature support on the workers side visible.
The development here is on hold while we're investigating the prod issues.
The basic idea of the implementation is as follows (and some notes):
waymark-start-workers, and playback to inject the workloads intowaymark-start-workers, replacing the real workers pool but using the real postgres backend (just queue instances from the pre-recorded file);wamark-vcr-fileto provides the shared implementation of reading and writing the vcr files, and well as the vcr files format;waymark-vcr-recorderandwaymark-vcr-playbackcrates in order to keep the integration layer with other major subsystems explicitly lightweight, with a small and limited scope that is easy to test;QueuedInstancetype and associated backend/executor operations would simplify building this feature, but not a blocker.UPD: added numbering so it's easier to reference items in discussion.