Skip to content

diffs: add CodeView.removeItem API - #1050

Merged
amadeus merged 4 commits into
mainfrom
amadeus/codeview-remove-item
Aug 4, 2026
Merged

diffs: add CodeView.removeItem API#1050
amadeus merged 4 commits into
mainfrom
amadeus/codeview-remove-item

Conversation

@amadeus

@amadeus amadeus commented Aug 3, 2026

Copy link
Copy Markdown
Member

Realized we didn't have a CodeView.removeItem API, despite having an addItem API... lol

@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pierre-docs-diffs Ready Ready Preview Aug 4, 2026 2:10am
pierre-docs-diffshub Ready Ready Preview Aug 4, 2026 2:10am
pierre-docs-trees Ready Ready Preview Aug 4, 2026 2:10am
pierrejs-diff-demo Ready Ready Preview Aug 4, 2026 2:10am

Request Review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d52c9de60

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/diffs/src/components/CodeView.ts
@amadeus
amadeus force-pushed the amadeus/codeview-remove-item branch from 2d52c9d to f00f212 Compare August 4, 2026 01:35
@amadeus

amadeus commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f00f212e6a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/diffs/src/components/CodeView.ts
There was some sloppiness from before with how selection callbacks were
being fired if the item was removed and had selections.
@amadeus

amadeus commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 3c96566f1e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@amadeus
amadeus merged commit 218def7 into main Aug 4, 2026
8 checks passed
@amadeus
amadeus deleted the amadeus/codeview-remove-item branch August 4, 2026 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant