Update syntax of contrast-color() function on marker popovers, ensure e2e test works - #1062
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7dfa7b383
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // contrast-color() always resolves to pure black or white, so any other | ||
| // value means the declaration was invalid and `color` fell back to the | ||
| // inherited editor foreground. | ||
| if (sample!.supportsContrastColor) { |
There was a problem hiding this comment.
In the inspected E2E configuration, the only project is the Chromium bundled with @playwright/test 1.51.1 (packages/diffs/test/e2e/playwright.config.ts:43-47, pnpm-workspace.yaml:65), which predates Chromium support for contrast-color(). Therefore this condition is false in every CI run and the new assertion is always skipped, so restoring the invalid two-argument declaration would still leave the regression test green. Run this check in a browser/channel that supports the function or add a test that actually exercises the supported declaration path.
Useful? React with 👍 / 👎.
|
@necolas I'm down for either PR! Left a code comment on yours about the fallback intent here for the CSS vars. |
|
Yeah interesting that the model didn't infer that! I'd point your agent at the other branch, suggest it adds a similar fallback test that we keep while the pw chromium lacks support for that CSS. Not a blocker on merging this fix |
amadeus
left a comment
amadeus
left a comment
There was a problem hiding this comment.
seems good to me! annoying lil syntax issue there. Not sure about the validity of the codex review though
|
Will follow up with another iteration that addresses comments here. |
3 participants
No description provided.