Remove unused vertical scrollbar gutter - #1064
Closed
jonatanklosko wants to merge 1 commit into
Closed
Conversation
|
@jonatanklosko is attempting to deploy a commit to the Pierre Computer Company Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
It’s very much intentional because it keeps bottom padding consistent around hunk separators. also it would break calculations in the virtualizers |
Contributor
Author
|
My understanding is that
Does it actually change the spacing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[data-code]hasoverflow-y: clip, andoverflow-x: scroll, so the effectiveoverflow-yis actuallyhidden. Consequently, the vertical scrollbar can never appear, butscrollbar-gutter: stablecan cause an empty gutter space to be reserved for the vertical scrollbar anyway. It does not always show up, but in our app it does show up in some cases and removingscrollbar-gutter: stablefixes that.Given that
scrollbar-gutter: stableonly impacts the inline axis, here the vertical scrollbar, and said scrollbar should never appear, it seems like reserving a gutter is never desirable. I may be missing the original intent of the rule being added though.