feat: prebuilt GHCR devcontainer image + simplified F5 launch - #446
Open
piers-sinclair wants to merge 2 commits into
Open
feat: prebuilt GHCR devcontainer image + simplified F5 launch#446piers-sinclair wants to merge 2 commits into
piers-sinclair wants to merge 2 commits into
Conversation
Mirrors the changes applied to DwellAround in PRs #57 and #63. Prebuilt image: - Add Dockerfile baking in all stable tooling: .NET 10, Node 22, pnpm, PostgreSQL client, Docker CLI, GitHub CLI, Azure CLI, dotnet-ef, Dostar.Cli, claude-code, Trivy, OpenGrep, Playwright Chromium, plus pre-warmed pnpm store and NuGet cache - Add devcontainer-image.yml CI workflow to publish dostar-devcontainer - Remove devcontainer features and onCreateCommand (tooling in image) - Delete devcontainer-lock.json (features lock, no longer applicable) - configure-git-mounts: reference dostar-devcontainer image, add docker socket + playwright/pnpm/nuget volumes, fix container_workspace case - postCreate: guard all tool installs, remove Trivy/OpenGrep wget, add UI test pnpm install and Playwright browser check - postStart: add postStart.log, docker socket fix, 15-retry PG wait, run migrations on every start - postAttach: fix repair hints, add playwright check, add start log line Simplified F5 launch: - launch: prepare now only builds Dostar.Api (postStart runs migrations) - Add run: reset-db task for manual migration re-apply - run: backend now depends on launch: prepare (not run: migrate directly) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PNPM_CONFIG_CONFIRM_MODULES_PURGE=false prevents pnpm from hanging on a y/n prompt when the node_modules volume needs to be purged. Mirrors fix from DwellAround PR #64. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the devcontainer improvements from DwellAround PRs #57 and #63 to the Dostar template.
Prebuilt GHCR image:
Simplified F5 launch:
First-time setup after merge
After CI publishes the first image, set the GHCR package to Public:
GitHub profile -> Packages -> dostar-devcontainer -> Package settings -> Change visibility -> Public
Test plan
Generated with Claude Code