This repository was archived by the owner on Mar 18, 2026. It is now read-only.
Some Python 3 Unicode improvements#7
Open
TWAC wants to merge 3 commits intopiersharding:masterfrom
Open
Conversation
added 3 commits
March 20, 2014 15:43
Seem to be the common style for Python 2 and 3 compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few commits regarding Python 3 compatibility, but I could not even get basic.py to work.
I made a few changes so that queries work for me.
The PyString / PyBytes change is not strictly necessary, but makes things more easy to understand when working towards Python 3 compatibility.
I suspect that there are more places that should be changed to accept or return unicode instead of bytes, particularly among the set functions.