Skip to content

chore: does master build?#111

Closed
ilikejames wants to merge 1 commit intopillarjs:masterfrom
ilikejames:chore/ensure-build-actually-works-without-lockfile
Closed

chore: does master build?#111
ilikejames wants to merge 1 commit intopillarjs:masterfrom
ilikejames:chore/ensure-build-actually-works-without-lockfile

Conversation

@ilikejames
Copy link

@ilikejames ilikejames commented Mar 29, 2023

I'm getting in node@4.9.0 on master locally, and a similar failure on PR-110.

npm ERR! ENOTDIR: not a directory, open '*/router/node_modules/eslint-plugin-markdown/node_modules/mdast-util-from-markdown/node_modules/@types/mdast/package.json'

Adding this PR as a test as a check if master builds correctly.


Edit: This on a clean environment with rm -rf node_modules and npm cache clean

@ilikejames ilikejames changed the title chore: does master build chore: does master build? Mar 29, 2023
@ilikejames
Copy link
Author

Ok, it does.

@ilikejames ilikejames closed this Mar 29, 2023
@ilikejames ilikejames deleted the chore/ensure-build-actually-works-without-lockfile branch March 29, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant