Add a helpful error message when pathRegexp fails#158
Open
JL102 wants to merge 1 commit intopillarjs:masterfrom
Open
Add a helpful error message when pathRegexp fails#158JL102 wants to merge 1 commit intopillarjs:masterfrom
JL102 wants to merge 1 commit intopillarjs:masterfrom
Conversation
bjohansebas
reviewed
Apr 11, 2025
| }); | ||
| } | ||
| catch (err) { | ||
| console.error(err); |
Member
There was a problem hiding this comment.
I’d prefer to merge the message you’re suggesting with the error message, rather than logging the error to the console and then throwing a new one
Member
|
Look pillarjs/path-to-regexp#363, I think it's better to do this in path-to-regexp than in the router |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered this issue when migrating from Express v4 to v5. When I had route strings like '/*', it failed, but the error message I got was quite vague (but worse, it does NOT point to my violating line of code or show my violating string):
Adding this try-catch will still spit out the error message provided by path-to-regexp, which points to their documentation where we can read more about the issue, but more importantly, the new error message/stack will contain the violating string and line of source code.