layer: use empty object without prototype for params of regexp path#185
Open
bjohansebas wants to merge 1 commit intopillarjs:masterfrom
Open
layer: use empty object without prototype for params of regexp path#185bjohansebas wants to merge 1 commit intopillarjs:masterfrom
bjohansebas wants to merge 1 commit intopillarjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as was discovered here expressjs/expressjs.com#2092, params will have an object with a prototype depending on whether its path is a string or a regexp, this PR tries to unify so that both are without a prototype, given that for a string path the params are created without a prototype here, whereas when it's a regexp it's created here
we consider this a breaking change? I don't think so, the impact would be minimal and I don't think anyone is accessing the prototype of params