tests: raise check-layers coverage from 49% to 88%#1
Merged
Conversation
Add zz_integration_test.go: drives main() end-to-end against tiny in-tmp Go modules, plus direct goList coverage (happy path, --tests, error path) and the loadLayersYAML walk-up fallback. Track the previously-untracked zz_helpers_test.go alongside. Per-function: main 0->75%, goList 0->88%, loadLayersYAML 80->100%. Only os.Exit branches (fatalf, hard violation, go list crash) remain uncovered.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zz_integration_test.godrivingmain()end-to-end against small in-tmp Go modules: happy path,--testsmode, default./...fallback, transitional-warning branch, and side-channel bypass branch.goListdirectly (happy path, with-tests dedup of synthetic*.testpackages, error path on a missing import).loadLayersYAMLcwd walk-up fallback (previously the only uncovered branch in that fn).zz_helpers_test.goso the suite is reproducible.Coverage
zz_helpers_test.go) / 30.6% onmainHEAD.go test -race -coverprofile=coverage.out -covermode=atomic ./...).main0%->75.3%,goList0%->87.5%,loadLayersYAML80%->100%.os.Exit(fatalf, theos.Exit(1)violation branch,goList's decode-error branch).Test plan
go test -race -count=1 -timeout 120s ./...passes (1.66s).go test -race -coverprofile=coverage.out -covermode=atomic ./...(CI command) passes at 88.4%.*_test.goadditions.runMainIn,goListcallers) are sequential to avoid races against parallel suites.