security: crypto.Verify rejects wrong-length public keys (panic-DoS fix)#39
Merged
Conversation
ed25519.Verify panics on a public key that is not exactly 32 bytes. crypto.Verify is reached from unauthenticated message paths (e.g. the handshake decodes a peer-supplied public_key and calls it), so a wrong-length key was a remote, unauthenticated crash. Guard the length and return false instead of panicking. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ed25519.Verifypanics on a public key that isn't exactly 32 bytes, andcrypto.Verifyis reached from unauthenticated paths (the handshake decodes a peer-suppliedpublic_keyand verifies it with no length check) — a remote, unauthenticated crash-DoS. Guard the length, return false. Regression test covers 0/1/5/31/33/64-byte + nil keys.🤖 Generated with Claude Code