Skip to content

test(web4): fix TestSetTagsDashboardAPI against admin-gated /api/stats #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TeoSlayer merged 2 commits into from
Jul 27, 2026
Merged

test(web4): fix TestSetTagsDashboardAPI against admin-gated /api/stats #431

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
691e6ff
test(web4): authenticate TestSetTagsDashboardAPI against admin-gated …
claude Jul 27, 2026
7fd3585
test(web4): assert tag privacy against /api/public-stats, not the gat…
claude Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 29 additions & 3 deletions tests/zz_tags_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,9 @@ func TestSetTagsDashboardAPI(t *testing.T) {
t.Parallel()

r := registry.New("127.0.0.1:9001")
// /api/stats is admin-gated (rich payload sits behind requireAdminToken);
// configure a token so the operator view is reachable from this test.
r.SetAdminToken(TestAdminToken)
go r.ListenAndServe("127.0.0.1:0")
<-r.Ready()
defer r.Close()
Expand Down Expand Up @@ -280,8 +283,9 @@ func TestSetTagsDashboardAPI(t *testing.T) {
var client http.Client
client.Timeout = 2 * time.Second
var httpResp *http.Response
statsURL := fmt.Sprintf("http://%s/api/stats?admin_token=%s", dashAddr, TestAdminToken)
for i := 0; i < 20; i++ {
httpResp, err = client.Get(fmt.Sprintf("http://%s/api/stats", dashAddr))
httpResp, err = client.Get(statsURL)
if err == nil {
break
}
Expand All @@ -292,6 +296,10 @@ func TestSetTagsDashboardAPI(t *testing.T) {
}
defer httpResp.Body.Close()

if httpResp.StatusCode != http.StatusOK {
t.Fatalf("GET /api/stats = %d, want 200", httpResp.StatusCode)
}

var stats registry.DashboardStats
body, _ := io.ReadAll(httpResp.Body)
if err := json.Unmarshal(body, &stats); err != nil {
Expand Down Expand Up @@ -326,8 +334,11 @@ func TestSetTagsDashboardNoHostname(t *testing.T) {
var client http.Client
client.Timeout = 2 * time.Second
var httpResp *http.Response
// The anonymous surface is /api/public-stats; /api/stats is admin-gated
// and would answer 401, which would satisfy the assertion below without
// ever inspecting a real payload.
for i := 0; i < 20; i++ {
httpResp, err = client.Get(fmt.Sprintf("http://%s/api/stats", dashAddr))
httpResp, err = client.Get(fmt.Sprintf("http://%s/api/public-stats", dashAddr))
if err == nil {
break
}
Expand All @@ -338,8 +349,15 @@ func TestSetTagsDashboardNoHostname(t *testing.T) {
}
defer httpResp.Body.Close()

if httpResp.StatusCode != http.StatusOK {
t.Fatalf("GET /api/public-stats = %d, want 200", httpResp.StatusCode)
}

body, _ := io.ReadAll(httpResp.Body)
bodyStr := string(body)
if len(bodyStr) == 0 {
t.Fatal("empty /api/public-stats body — assertion would pass vacuously")
}

// Dashboard JSON should NOT contain hostname field
if strings.Contains(bodyStr, "\"hostname\"") {
Expand Down Expand Up @@ -369,8 +387,9 @@ func TestSetTagsDashboardNoIPLeak(t *testing.T) {
var client http.Client
client.Timeout = 2 * time.Second
var httpResp *http.Response
// Anonymous surface — see the note in TestSetTagsDashboardNoHostname.
for i := 0; i < 20; i++ {
httpResp, err = client.Get(fmt.Sprintf("http://%s/api/stats", dashAddr))
httpResp, err = client.Get(fmt.Sprintf("http://%s/api/public-stats", dashAddr))
if err == nil {
break
}
Expand All @@ -381,8 +400,15 @@ func TestSetTagsDashboardNoIPLeak(t *testing.T) {
}
defer httpResp.Body.Close()

if httpResp.StatusCode != http.StatusOK {
t.Fatalf("GET /api/public-stats = %d, want 200", httpResp.StatusCode)
}

body, _ := io.ReadAll(httpResp.Body)
bodyStr := string(body)
if len(bodyStr) == 0 {
t.Fatal("empty /api/public-stats body — assertions would pass vacuously")
}

if strings.Contains(bodyStr, "127.0.0.1") {
t.Fatal("API response leaks 127.0.0.1")
Expand Down
Loading