Skip to content

Fix deprecation of EsSyncCommand #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fashxp merged 2 commits into from
Nov 26, 2025
Merged

Fix deprecation of EsSyncCommand #285

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
810fad8
Fix deprecation of `EsSyncCommand`
jdreesen Nov 25, 2025
9ba4787
Fix version
jdreesen Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/Command/IndexService/EsSyncCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,6 @@ protected function configure(): void
{
parent::configure();

trigger_deprecation(
'pimcore/ecommerce-framework-bundle',
'2.0.0',
'The command "%s" is deprecated and will be removed in a future version. Please use the ecommerce:indexservice:search-index-sync instead.',
$this->getName()
);

$this
->setName('ecommerce:indexservice:elasticsearch-sync')
->setDescription(
Expand All @@ -60,6 +53,13 @@ protected function configure(): void

protected function execute(InputInterface $input, OutputInterface $output): int
{
trigger_deprecation(
'pimcore/ecommerce-framework-bundle',
'1.3',
'The command "%s" is deprecated and will be removed in a future version. Please use the ecommerce:indexservice:search-index-sync instead.',
$this->getName()
);

$mode = $input->getArgument('mode');
$tenantName = $input->getOption('tenant');

Expand Down