Conversation
|
Corepex
deleted the
3161-localization-add-new-locale-xx-yyxx_yy-does-not-workmakes-system_settings-inaccessible-v2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #3161
Additional info
This pull request updates the language selection logic in the system settings localization form to ensure consistent handling of language codes by normalizing hyphens to underscores. This prevents duplicate entries and ensures fallback languages are correctly initialized.
Language code normalization:
language-select.tsx, language codes are normalized by replacing hyphens with underscores when filtering out already selected languages, preventing duplicates due to differing formats.localization-collapse.tsx, selected language codes are normalized before adding tovalid_languages, and corresponding entries infallback_languagesare initialized, ensuring consistency and proper initialization in the form state.