Read all 16 possible wind direction values#163
Open
sjefferson99 wants to merge 6 commits intopimoroni:mainfrom
Open
Read all 16 possible wind direction values#163sjefferson99 wants to merge 6 commits intopimoroni:mainfrom
sjefferson99 wants to merge 6 commits intopimoroni:mainfrom
Conversation
sjefferson99
force-pushed
the
wind-direction-improvement
branch
from
2426dd6 to
e5f2613
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ZodiusInfuser This is your code, so feel free to replace with your own PR, but this is the code tested in issue #114 to make it easier to further test and confirm changes made.
Loop to gain two matching consecutive readings was removed after testing, as it seems the errors were from intermediate readings not being understood by the 8 position code.
I have also added an optional offset value to the config file (with appropriate defaults and checks for older config files) as this code adjusts the reported value by 180 degrees to match the datasheet and some stations may not be readily physically adjusted.